From best to worst, I would say

Lupin-He knew the subject well, and knew how to teach and connect to students

Crouch-He knew the subject well, and knew how to teach and connect to students, but he was also evil

Snape-He knew the subject well, but did not have enough patience to be an effective teacher

Quirrell-From what we’ve seen, he was a perfectly competent but unmemorable teacher. Also, he was evil.

Lockhart-He was good at connecting with students, but he was an idiot who knew nothing about his subject.

Umbridge- She was a sadist who was actively trying not to teach.

Carrow- He was a sadist who was actively teaching the opposite of what he was supposed to.